robertwb commented on a change in pull request #14783:
URL: https://github.com/apache/beam/pull/14783#discussion_r630597433
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -299,6 +299,9 @@ def _replace_if_needed(self, original_transform_node):
original_transform_node.full_label,
original_transform_node.inputs)
+ replacement_transform_node.resource_hints = (
+ original_transform_node.resource_hints)
Review comment:
I don't think environment or annotations are used for any non-portable
runner (and it's also unclear if they should be preserved or overwritten).
Hopefully we'll be in a position to move to all-portable runners soon and we
and just get rid of all of this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]