[GitHub] [beam] kennknowles commented on a change in pull request #14801: [BEAM-10670] Use non-SDF based translation for Read by default on all runners except Dataflow

[GitBox]

kennknowles commented on a change in pull request #14801:
URL: https://github.com/apache/beam/pull/14801#discussion_r631460477



##########
File path: 
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDo.java
##########
@@ -652,7 +652,9 @@ public void tearDown() {
    * <p>TODO(BEAM-10670): Remove the primitive Read and make the splittable 
DoFn the only option.
    */
   public static void 
convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(Pipeline pipeline) {
-    if (ExperimentalOptions.hasExperiment(pipeline.getOptions(), 
"beam_fn_api_use_deprecated_read")
+    if (!ExperimentalOptions.hasExperiment(pipeline.getOptions(), 
"use_sdf_read")
+        || ExperimentalOptions.hasExperiment(

Review comment:
       @pulasthi is this issue something that affects you or that you have 
noticed?

##########
File path: 
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDo.java
##########
@@ -652,7 +652,9 @@ public void tearDown() {
    * <p>TODO(BEAM-10670): Remove the primitive Read and make the splittable 
DoFn the only option.
    */
   public static void 
convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(Pipeline pipeline) {
-    if (ExperimentalOptions.hasExperiment(pipeline.getOptions(), 
"beam_fn_api_use_deprecated_read")
+    if (!ExperimentalOptions.hasExperiment(pipeline.getOptions(), 
"use_sdf_read")

Review comment:
       @xinyuiscool is this issue something that affects you or that you have 
noticed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org