calvinleungyk commented on a change in pull request #15105:
URL: https://github.com/apache/beam/pull/15105#discussion_r667149712
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -526,6 +534,14 @@ def _create_jar_packages(jar_packages, temp_dir):
return resources
+ @staticmethod
+ def _should_download_remote_extra_packages(package):
Review comment:
I agree we can remove it, but I was hesitant because I wasn't sure if
that would break existing use cases (i.e. non HTTP downloads) although it seems
to be low risk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
