hmc-cs-mdrissi commented on a change in pull request #15415:
URL: https://github.com/apache/beam/pull/15415#discussion_r708105188
##########
File path: sdks/python/apache_beam/utils/proto_utils.py
##########
@@ -40,13 +40,13 @@
@overload
def pack_Any(msg):
# type: (message.Message) -> any_pb2.Any
- pass
+ ...
Review comment:
pass vs ... are similar but not same. pass has an inferred return type
of None for some type checkers. Pyright will give you an error for using pass
here. ... is typical way to mark overloads as stubs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
