hmc-cs-mdrissi commented on a change in pull request #15415:
URL: https://github.com/apache/beam/pull/15415#discussion_r708111686
##########
File path: sdks/python/apache_beam/utils/proto_utils.py
##########
@@ -40,13 +40,13 @@
@overload
def pack_Any(msg):
# type: (message.Message) -> any_pb2.Any
- pass
+ ...
Review comment:
Are test files even type checked? I tried running mypy on this file and
got an error. Also discovered mypy.ini for the repo has an invalid value giving
this error message,
`mypy.ini: [mypy]: follow_imports: invalid choice 'true' (choose from
'normal', 'silent', 'skip', 'error')`
The mypy error that prevents it from type checking this file is,
`apache_beam/portability/api/metrics_pb2.pyi:117: error: invalid syntax
[syntax]` Looks like root cause of that error is a comment using type: notation
for doc string and confusing it with standard type comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
