egalpin commented on pull request #16309: URL: https://github.com/apache/beam/pull/16309#issuecomment-1012248745
Thanks @khersey for adding the common method for the tests! I admit that the testing setup for Elasticsearch could be improved, but this new method you've add will need to be invoked in each of the unit test files (one for each support ES version) named `ElasticsearchIOTest.java` found here: https://github.com/apache/beam/tree/master/sdks/java/io/elasticsearch-tests Ex. elasticsearch 7 test suite: https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch-tests/elasticsearch-tests-7/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTest.java This is where your new test will be invoked from; presently the method you added is not invoked by the test runner. Please ping back here if you continue to be blocked by the jcenter issue you posted previously. If you're unblocked on that, you can invoke test suites locally by using gradle: ```./gradlew --info :sdks:java:io:elasticsearch-tests:elasticsearch-tests-7:test``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
