KhaninArtur commented on a change in pull request #17080:
URL: https://github.com/apache/beam/pull/17080#discussion_r829122590
##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -76,18 +112,18 @@ func TestValidator(t *testing.T) {
// As a result, want to receive an expected validator
builder.
name: "Test correct validator builder",
args: args{
- paths: paths,
- sdkEnv: sdkEnv,
+ paths: pythonPaths,
+ sdkEnv: pythonSdkEnv,
Review comment:
Should we do the same for Java, Go and SCIO SDKs?
##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -143,16 +179,16 @@ func TestPreparer(t *testing.T) {
{
// Test case with calling Setup with incorrect SDK.
// As a result, want to receive an error.
- name: "incorrect sdk",
- args: args{*paths, pipelineOptions, wrongSdkEnv,
&validationResults},
+ name: "Incorrect sdk",
+ args: args{*pythonPaths, pipelineOptions,
wrongSdkEnv, &validationResults},
want: nil,
wantErr: true,
},
{
// Test case with calling Setup with correct SDK.
// As a result, want to receive an expected preparer
builder.
- name: "correct sdk",
- args: args{*paths, pipelineOptions, sdkEnv,
&validationResults},
+ name: "Correct sdk",
+ args: args{*pythonPaths, pipelineOptions,
pythonSdkEnv, &validationResults},
Review comment:
ditto
##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -195,10 +231,10 @@ func TestCompiler(t *testing.T) {
{
// Test case with calling Setup with correct data.
// As a result, want to receive an expected compiler
builder.
- name: "Test correct compiler builder",
+ name: "Test correct compiler builder with java sdk",
Review comment:
Should we do the same test for Go and SCIO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
