pavel-avilov commented on a change in pull request #17080:
URL: https://github.com/apache/beam/pull/17080#discussion_r832043255
##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -143,16 +179,16 @@ func TestPreparer(t *testing.T) {
{
// Test case with calling Setup with incorrect SDK.
// As a result, want to receive an error.
- name: "incorrect sdk",
- args: args{*paths, pipelineOptions, wrongSdkEnv,
&validationResults},
+ name: "Incorrect sdk",
+ args: args{*pythonPaths, pipelineOptions,
wrongSdkEnv, &validationResults},
want: nil,
wantErr: true,
},
{
// Test case with calling Setup with correct SDK.
// As a result, want to receive an expected preparer
builder.
- name: "correct sdk",
- args: args{*paths, pipelineOptions, sdkEnv,
&validationResults},
+ name: "Correct sdk",
+ args: args{*pythonPaths, pipelineOptions,
pythonSdkEnv, &validationResults},
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
