damccorm commented on code in PR #17735:
URL: https://github.com/apache/beam/pull/17735#discussion_r879812094
##########
sdks/go/pkg/beam/pardo.go:
##########
@@ -63,7 +65,8 @@ func TryParDo(s Scope, dofn interface{}, col PCollection,
opts ...Option) ([]PCo
return nil, fmt.Errorf("main input is global windowed
in DoFn %v but side input %v is not, cannot map windows correctly. Consider
re-windowing the side input PCollection before use", fn, i)
}
if (sideWfn.Kind == window.GlobalWindows) &&
!sideNode.Bounded() {
- return nil, fmt.Errorf("side input %v is global
windowed in DoFn %v but is unbounded, DoFn will block until end of Global
Window. Consider windowing your unbounded side input PCollection before use",
i, fn)
+ // TODO(BEAM-14501): Replace this warning with an error
return when proper streaming test functions have been added.
+ log.Warnf(context.Background(), "side input %v is
global windowed in DoFn %v but is unbounded, DoFn will block until end of
Global Window. Consider windowing your unbounded side input PCollection before
use", i, fn)
Review Comment:
If we're planning on upgrading this to an error, I would say that as part of
the warning. That saves us the work of needing to do that sort of rollout work
in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
