chamikaramj commented on code in PR #16939:
URL: https://github.com/apache/beam/pull/16939#discussion_r883905589
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -402,6 +404,28 @@ public Read withRowFilter(RowFilter filter) {
return withRowFilter(StaticValueProvider.of(filter));
}
+ /**
+ * Returns a new {@link BigtableIO.Read} that will break up read requests
into smaller batches.
+ * This function will switch the base BigtableIO.Reader class to using the
SegmentReader. If
+ * null is passed, this behavior will be disabled and the stream reader
will be used.
+ *
+ * <p>Does not modify this object.
+ *
+ * <p>When we have a builder, we initialize the value. When they call the
method then we
+ * override the value
+ */
+ @Experimental(Kind.SOURCE_SINK)
+ public Read withMaxBufferElementCount(@Nullable Integer
maxBufferElementCount) {
Review Comment:
Can we add an end-to-end integration test for this (can be done in a
separate PR) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
