Abacn commented on code in PR #17708:
URL: https://github.com/apache/beam/pull/17708#discussion_r886254969
##########
sdks/python/apache_beam/io/fileio.py:
##########
@@ -525,8 +526,11 @@ def __init__(
@staticmethod
def _get_sink_fn(input_sink):
# type: (...) -> Callable[[Any], FileSink]
- if isinstance(input_sink, FileSink):
- return lambda x: input_sink
+ if isinstance(input_sink, type) and issubclass(input_sink, FileSink):
Review Comment:
Sorry, previously sink=fileio.TextSink would not work either. It would try
to call `fileio.TextSink(destination)`
[here](https://github.com/apache/beam/blob/d0c0dee32cf42fdaeb4e9b1556419906eb104029/sdks/python/apache_beam/io/fileio.py#L805)
and get a TypeError of mismatch constructor parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
