Abacn commented on code in PR #17708:
URL: https://github.com/apache/beam/pull/17708#discussion_r886978987
##########
sdks/python/apache_beam/io/fileio.py:
##########
@@ -525,8 +526,11 @@ def __init__(
@staticmethod
def _get_sink_fn(input_sink):
# type: (...) -> Callable[[Any], FileSink]
- if isinstance(input_sink, FileSink):
- return lambda x: input_sink
+ if isinstance(input_sink, type) and issubclass(input_sink, FileSink):
Review Comment:
> I guess the only thing that worked before was either passing callable or
None.
Yes exactly;
> Was there anyway to pass FileSink or FileSink() or any other variation
here?
Passing FileSink() could work if there was only one destination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
