comphead commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576794138
##########
core/src/execution/datafusion/expressions/cast.rs:
##########
@@ -64,6 +68,25 @@ pub struct Cast {
pub timezone: String,
}
+macro_rules! spark_cast_utf8_to_integral {
Review Comment:
maybe `utf8_to_integer`?
spark not involved in native exec, not sure why spark is needed.
Integral type also includes booleans and this scope limited by integers afaik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
