erratic-pattern commented on PR #10221: URL: https://github.com/apache/datafusion/pull/10221#issuecomment-2077734372
> > I think it's now complaining that the type is no longer an integer and is instead Dictionary<Int32, Int8> > > That seems like you could just update the test. Perhaps via https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest#updating-tests-completion-mode I updated the tests, but I'm still unsure if it's okay to ignore this change in behavior. It seems like this could be a regression in other cases where we might be converting things to dictionaries for no reason. It would be nice to have some issue tracking this, or maybe there is one already. A possibly easy change to make in the short-term is to refactor away from using `comparison_coercion` for non-comparisons and instead use coercion logic specifically tailored to those expressions. I just feels like we're playing Jenga with type coercion logic right now. The coercion logic should prioritize avoiding expensive casts, I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
