Jefffrey commented on code in PR #10242:
URL: https://github.com/apache/datafusion/pull/10242#discussion_r1580893225
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -467,7 +467,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
expr,
substring_from,
substring_for,
- special: false,
+ ..
Review Comment:
```suggestion
special: _
```
Maybe this so we can be informed of any new fields in Substring in the
future?
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -476,13 +476,6 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
planner_context,
),
- #[cfg(not(feature = "unicode_expressions"))]
- SQLExpr::Substring { .. } => {
- internal_err!(
- "statement substring requires compilation with feature
flag: unicode_expressions."
- )
- }
Review Comment:
I think this might still be needed?
##########
datafusion/sqllogictest/test_files/expr.slt:
##########
@@ -1871,6 +1871,17 @@ SELECT digest('','blake3');
----
af1349b9f5f9a1a6a0404dea36dcc9499bcb25c9adc112b7cc9a93cae41f3262
+
+query T
+SELECT substring('alphabet', 1)
+----
+alphabet
+
+query T
+SELECT substring('alphabet', 3, 2)
+----
+ph
Review Comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
