alamb opened a new pull request, #10331:
URL: https://github.com/apache/datafusion/pull/10331

   ## Which issue does this PR close?
   
   Closes https://github.com/apache/datafusion/issues/3793
   
   
   ## Rationale for this change
   
   1. Permit making an API for 
https://github.com/apache/datafusion/issues/10181 that takes a `&DFSchema` 
rather than an owned
   2. Avoid a copy and thus make the API marginally faster in some cases. 
   
   
   ## What changes are included in this PR?
   Change `coerce` API from 
   
   ```
       pub fn coerce(&self, expr: Expr, schema: DFSchemaRef) -> Result<Expr> {
   ```
   
   to
   
   ```rust
       pub fn coerce(&self, expr: Expr, schema: &DFSchema) -> Result<Expr> {
   ```
   
   ## Are these changes tested?
   By existing CI
   
   ## Are there any user-facing changes?
   
   The API to call coerce is slightly changed. Note I am in the process of 
adding a proper fully baked API in 
https://github.com/apache/datafusion/issues/10181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to