planga82 commented on code in PR #365:
URL: https://github.com/apache/datafusion-comet/pull/365#discussion_r1586685070
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -383,6 +383,13 @@ object CometConf {
.booleanConf
.createWithDefault(false)
+ val COMET_SORTMERGEJOIN_CHECK_KEY_TYPES: ConfigEntry[Boolean] =
Review Comment:
thanks @comphead . Any idea how to do this in a cleaner way? We could move
this constant to other place and avoid putting it in CometConf. In that way we
avoid to expose a testing configuration. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
