metesynnada commented on PR #10309: URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2089827370
> Hmm, I don't get the point. How should I add unit tests? The executor should be capable of running independently within a test. For more insight, refer to the hash join tests in datafusion/physical-plan/src/joins/hash_join.rs. Your tests ofc will be much more simple. Currently, a GlobalLimitExec is already implemented at the top of the tests, which means these tests wouldn't fail if the limit implementation in StreamingTableExec were to change." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
