alamb commented on code in PR #10330:
URL: https://github.com/apache/datafusion/pull/10330#discussion_r1587512649
##########
datafusion/common/src/dfschema.rs:
##########
@@ -806,6 +820,12 @@ impl From<&DFSchema> for Schema {
}
}
+impl AsRef<Schema> for DFSchema {
Review Comment:
yeah, https://github.com/apache/datafusion/pull/9595 was epic -- kudos to
@haohuaijin for making that happen
##########
datafusion/common/src/dfschema.rs:
##########
@@ -806,6 +820,12 @@ impl From<&DFSchema> for Schema {
}
}
+impl AsRef<Schema> for DFSchema {
Review Comment:
yeah, https://github.com/apache/datafusion/pull/9595 was epic -- kudos to
@haohuaijin and @matthewmturner for making that happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
