andygrove commented on code in PR #362:
URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1588326109
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -376,12 +376,15 @@ object CometConf {
.booleanConf
.createWithDefault(false)
- val COMET_CAST_STRING_TO_TIMESTAMP: ConfigEntry[Boolean] = conf(
- "spark.comet.cast.stringToTimestamp")
- .doc(
- "Comet is not currently fully compatible with Spark when casting from
String to Timestamp.")
- .booleanConf
- .createWithDefault(false)
+ val COMET_CAST_ALLOW_INCOMPATIBLE: ConfigEntry[Boolean] =
+ conf("spark.comet.cast.allowIncompatible")
+ .doc(
+ "Comet is not currently fully compatible with Spark for all cast
operations. " +
+ "Set this config to true to allow them anyway. See compatibility
guide " +
+ "for more information.")
+ .booleanConf
+ // TODO change this to false and set this config explicitly in tests
where needed
+ .createWithDefault(true)
Review Comment:
I will create a separate PR to change the default value and update any tests
that need it, after this PR is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
