andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1588328731
########## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ########## @@ -559,6 +569,12 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { castFallbackTestTimezone(values.toDF("a"), DataTypes.TimestampType, "Unsupported timezone") } + // CAST from BinaryType + + ignore("cast BinaryType to StringType") { + // TODO + } Review Comment: Implementing this new test is unrelated to this PR. I will file a new issue for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org