andygrove commented on code in PR #362:
URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1588340857
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -515,23 +516,32 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(values, DataTypes.createDecimalType(10, 2))
}
+ test("cast StringType to BinaryType") {
+ castTest(generateStrings(numericPattern, 8).toDF("a"),
DataTypes.BinaryType)
+ }
+
ignore("cast StringType to DateType") {
// https://github.com/apache/datafusion-comet/issues/327
castTest(generateStrings(datePattern, 8).toDF("a"), DataTypes.DateType)
}
test("cast StringType to TimestampType disabled by default") {
val values = Seq("2020-01-01T12:34:56.123456", "T2").toDF("a")
- castFallbackTest(
- values.toDF("a"),
- DataTypes.TimestampType,
- "spark.comet.cast.stringToTimestamp is disabled")
+ castFallbackTest(values.toDF("a"), DataTypes.TimestampType, "Unsupported
timezone")
+ }
+
+ ignore("cast StringType to TimestampType (fuzz test)") {
+ // https://github.com/apache/datafusion-comet/issues/328
+ withSQLConf((CometConf.COMET_CAST_ALLOW_INCOMPATIBLE.key, "true")) {
+ val values = Seq("2020-01-01T12:34:56.123456", "T2") ++
generateStrings(timestampPattern, 8)
+ castTest(values.toDF("a"), DataTypes.TimestampType)
+ }
}
Review Comment:
This is unrelated to this PR but got dropped when a recent PR was merged, so
I am adding it back here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
