snmvaughan commented on code in PR #362:
URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1589245486
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -65,29 +67,12 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
} else if (!testExists) {
fail(s"Missing test: $expectedTestName")
}
- } else if (testExists) {
- fail(s"Found test for cast that Spark does not support:
$expectedTestName")
Review Comment:
Was there a particular test that was incorrectly failing due to this check?
##########
docs/source/user-guide/configs.md:
##########
@@ -25,7 +25,7 @@ Comet provides the following configuration settings.
|--------|-------------|---------------|
| spark.comet.ansi.enabled | Comet does not respect ANSI mode in most cases
and by default will not accelerate queries when ansi mode is enabled. Enable
this setting to test Comet's experimental support for ANSI mode. This should
not be used in production. | false |
| spark.comet.batchSize | The columnar batch size, i.e., the maximum number of
rows that a batch can contain. | 8192 |
-| spark.comet.cast.stringToTimestamp | Comet is not currently fully compatible
with Spark when casting from String to Timestamp. | false |
+| spark.comet.cast.allowIncompatible | Comet is not currently fully compatible
with Spark for all cast operations. Set this config to true to allow them
anyway. See compatibility guide for more information. | true |
Review Comment:
Shouldn't this document that it defaults to `false`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
