erratic-pattern commented on code in PR #10358: URL: https://github.com/apache/datafusion/pull/10358#discussion_r1588461529
########## datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs: ########## @@ -107,6 +110,7 @@ impl<S: SimplifyInfo> ExprSimplifier<S> { info, guarantees: vec![], canonicalize: true, + max_simplifier_iterations: DEFAULT_MAX_SIMPLIFIER_ITERATIONS, Review Comment: Right now there's no reason to have a struct field, but the idea is that we might want to make this configurable later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org