alamb commented on code in PR #10360:
URL: https://github.com/apache/datafusion/pull/10360#discussion_r1588466065
##########
datafusion/functions/src/math/log.rs:
##########
@@ -283,4 +289,52 @@ mod tests {
}
}
}
+ #[test]
+ // Test log() simplification errors
+ fn test_log_simplify_errors() {
+ let props = ExecutionProps::new();
+ let schema =
+ Arc::new(DFSchema::new_with_metadata(vec![],
HashMap::new()).unwrap());
+ let context = SimplifyContext::new(&props).with_schema(schema);
+ // Expect 0 args to arror
+ let _ = LogFunc::new().simplify(vec![], &context).unwrap_err();
+ // Expect 3 args to error
+ let _ = LogFunc::new()
+ .simplify(vec![lit(1), lit(2), lit(3)], &context)
+ .unwrap_err();
+ }
+
+ #[test]
+ // Test that non-simplifiable log() expressions are unchanged after
simplification
+ fn test_log_simplify_original() {
+ let props = ExecutionProps::new();
+ let schema =
+ Arc::new(DFSchema::new_with_metadata(vec![],
HashMap::new()).unwrap());
+ let context = SimplifyContext::new(&props).with_schema(schema);
+ // One argument with no simplifications
+ let result = LogFunc::new().simplify(vec![lit(2)], &context).unwrap();
+ match result {
+ ExprSimplifyResult::Simplified(_) => {
+ panic!("Expected ExprSimplifyResult::Original")
+ }
+ ExprSimplifyResult::Original(args) => {
+ assert_eq!(args.len(), 1);
+ assert_eq!(args[0], lit(2));
+ }
+ }
Review Comment:
(same for the other)
##########
datafusion/functions/src/math/log.rs:
##########
@@ -283,4 +289,52 @@ mod tests {
}
}
}
+ #[test]
+ // Test log() simplification errors
+ fn test_log_simplify_errors() {
+ let props = ExecutionProps::new();
+ let schema =
+ Arc::new(DFSchema::new_with_metadata(vec![],
HashMap::new()).unwrap());
+ let context = SimplifyContext::new(&props).with_schema(schema);
+ // Expect 0 args to arror
+ let _ = LogFunc::new().simplify(vec![], &context).unwrap_err();
+ // Expect 3 args to error
+ let _ = LogFunc::new()
+ .simplify(vec![lit(1), lit(2), lit(3)], &context)
+ .unwrap_err();
+ }
+
+ #[test]
+ // Test that non-simplifiable log() expressions are unchanged after
simplification
+ fn test_log_simplify_original() {
+ let props = ExecutionProps::new();
+ let schema =
+ Arc::new(DFSchema::new_with_metadata(vec![],
HashMap::new()).unwrap());
+ let context = SimplifyContext::new(&props).with_schema(schema);
+ // One argument with no simplifications
+ let result = LogFunc::new().simplify(vec![lit(2)], &context).unwrap();
+ match result {
+ ExprSimplifyResult::Simplified(_) => {
+ panic!("Expected ExprSimplifyResult::Original")
+ }
+ ExprSimplifyResult::Original(args) => {
+ assert_eq!(args.len(), 1);
+ assert_eq!(args[0], lit(2));
+ }
+ }
Review Comment:
Another way to write this perhaps more concisely and with less indenting
could be:
```suggestion
let ExprSimplifyResult::Original(args) = result else {
panic!("Expected ExprSimplifyResult::Original")
};
assert_eq!(args.len(), 1);
assert_eq!(args[0], lit(2));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
