alamb commented on code in PR #10358:
URL: https://github.com/apache/datafusion/pull/10358#discussion_r1588558562
##########
datafusion/optimizer/Cargo.toml:
##########
@@ -53,5 +53,6 @@ log = { workspace = true }
regex-syntax = "0.8.0"
[dev-dependencies]
ctor = { workspace = true }
+datafusion-functions = { workspace = true }
Review Comment:
Let's not do this -- we really need to avoid re-introducing dependencies
like this
Tests that need functions should go in
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/optimizer_integration.rs
I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
