andygrove commented on code in PR #348: URL: https://github.com/apache/datafusion-comet/pull/348#discussion_r1589075154
########## spark/src/test/resources/tpcds-query-results/v1_4/q39a.sql.out: ########## @@ -31,7 +31,7 @@ struct<w_warehouse_sk:int,i_item_sk:int,d_moy:int,mean:double,cov:double,w_wareh 1 12259 1 326.5 1.219693210219279 1 12259 2 292.6666666666667 1.2808898286830026 1 12641 1 321.25 1.1286221893301993 1 12641 2 279.25 1.129134558577743 1 13043 1 260.5 1.355894484625015 1 13043 2 295.0 1.056210118409035 -1 13157 1 260.5 1.5242630430075292 1 13157 2 413.5 1.0422561797285326 +1 13157 1 260.5 1.524263043007529 1 13157 2 413.5 1.0422561797285326 Review Comment: Ideally, it would be good to compare floating point numbers based on an epsilon to make sure they are within some tolerance threshold. I assume we are currently just comparing text file output directly? Do we have a way to generate the output into a structured file type such as CSV or JSON? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
