viirya commented on code in PR #348:
URL: https://github.com/apache/datafusion-comet/pull/348#discussion_r1591570021
##########
spark/src/test/scala/org/apache/spark/sql/CometTPCDSQuerySuite.scala:
##########
@@ -73,8 +73,12 @@ class CometTPCDSQuerySuite
"q36",
"q37",
"q38",
- "q39a",
- "q39b",
+ // TODO: comment 39a and 39b for now because the expected result for
stddev failed:
+ // expected: 1.5242630430075292, actual: 1.524263043007529.
+ // Will change the comparison logic to detect floating-point numbers
and compare
+ // with epsilon
+ // "q39a",
+ // "q39b",
Review Comment:
We should create a ticket for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
