jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1589169380
########## datafusion/sqllogictest/test_files/coalesce.slt: ########## @@ -35,7 +35,7 @@ select coalesce(null, null); NULL # cast to float -query RT +query IT Review Comment: I also notice that, it seems types are computed before the actual result, so the type is not coerced https://github.com/apache/datafusion/blob/6480020e695ebbe2b81e8971c3ee0e9e7ec124b0/datafusion/sqllogictest/src/engines/datafusion_engine/runner.rs#L73-L80 And, it is not a trivial fix, I tried to get the return type from batches, but failed on aggregate cases where the expected rows are different from the batches (input rows). (By not trivial, I mean it deserves another PR) Do you think we need to fix it prior to this PR? Given that we have arrow_typeof, I don't think it is necessary, but it is somehow confusing if we read carefully about the type besides `query`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
