jayzhan211 commented on code in PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#discussion_r1589872168
##########
datafusion/expr/src/udaf.rs:
##########
@@ -195,6 +197,21 @@ impl AggregateUDF {
pub fn create_groups_accumulator(&self) -> Result<Box<dyn
GroupsAccumulator>> {
self.inner.create_groups_accumulator()
}
+ /// Do the function rewrite
+ ///
+ /// See [`AggregateUDFImpl::simplify`] for more details.
+ pub fn simplify(
+ &self,
+ args: Vec<Expr>,
Review Comment:
I think we should reuse args in AggregateFunction
https://github.com/apache/datafusion/blob/8190cb97216e4f46faccbeddae57f6773587955f/datafusion/expr/src/expr.rs#L568-L582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
