viirya commented on code in PR #380:
URL: https://github.com/apache/datafusion-comet/pull/380#discussion_r1590347465
##########
spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala:
##########
@@ -957,7 +966,9 @@ class CometAggregateSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
test("first/last") {
withSQLConf(
+ SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "true",
CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true",
+ CometConf.COMET_SHUFFLE_ENFORCE_MODE_ENABLED.key -> "true",
Review Comment:
These tests are sensitive to partitioning, once coalesce partition is
disabled, they won't produce same results as Spark. So I added the
`COMET_SHUFFLE_ENFORCE_MODE_ENABLED` config to enforce Comet shuffle even
`COALESCE_PARTITIONS_ENABLED` is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
