alamb commented on PR #10386: URL: https://github.com/apache/datafusion/pull/10386#issuecomment-2096785896
Here are my measurements on my gcp machine (it does seem to help by 1-2%) <details><summary>Details</summary> <p> ``` ++ critcmp main loop-expr-simplifier-static-dispatch group loop-expr-simplifier-static-dispatch main ----- ------------------------------------ ---- logical_aggregate_with_join 1.00 1211.4±14.74µs ? ?/sec 1.00 1214.7±64.80µs ? ?/sec logical_plan_tpcds_all 1.00 156.4±1.31ms ? ?/sec 1.01 158.4±2.20ms ? ?/sec logical_plan_tpch_all 1.00 16.9±0.19ms ? ?/sec 1.00 16.9±0.17ms ? ?/sec logical_select_all_from_1000 1.00 18.6±0.17ms ? ?/sec 1.01 18.8±0.13ms ? ?/sec logical_select_one_from_700 1.00 814.0±10.94µs ? ?/sec 1.00 815.5±32.65µs ? ?/sec logical_trivial_join_high_numbered_columns 1.00 758.0±10.12µs ? ?/sec 1.00 759.1±19.82µs ? ?/sec logical_trivial_join_low_numbered_columns 1.00 743.0±8.02µs ? ?/sec 1.01 749.9±9.83µs ? ?/sec physical_plan_tpcds_all 1.00 1336.8±8.42ms ? ?/sec 1.01 1354.8±8.50ms ? ?/sec physical_plan_tpch_all 1.00 90.2±1.61ms ? ?/sec 1.03 93.1±1.37ms ? ?/sec physical_plan_tpch_q1 1.00 4.9±0.07ms ? ?/sec 1.06 5.1±0.09ms ? ?/sec physical_plan_tpch_q10 1.00 4.3±0.06ms ? ?/sec 1.02 4.4±0.08ms ? ?/sec physical_plan_tpch_q11 1.00 3.9±0.05ms ? ?/sec 1.02 4.0±0.06ms ? ?/sec physical_plan_tpch_q12 1.00 3.1±0.07ms ? ?/sec 1.00 3.1±0.08ms ? ?/sec physical_plan_tpch_q13 1.00 2.1±0.03ms ? ?/sec 1.04 2.2±0.06ms ? ?/sec physical_plan_tpch_q14 1.00 2.7±0.05ms ? ?/sec 1.06 2.8±0.05ms ? ?/sec physical_plan_tpch_q16 1.00 3.7±0.08ms ? ?/sec 1.04 3.8±0.09ms ? ?/sec physical_plan_tpch_q17 1.00 3.5±0.05ms ? ?/sec 1.02 3.6±0.06ms ? ?/sec physical_plan_tpch_q18 1.00 3.9±0.05ms ? ?/sec 1.00 3.9±0.07ms ? ?/sec physical_plan_tpch_q19 1.00 6.0±0.07ms ? ?/sec 1.03 6.2±0.08ms ? ?/sec physical_plan_tpch_q2 1.00 7.7±0.10ms ? ?/sec 1.02 7.9±0.06ms ? ?/sec physical_plan_tpch_q20 1.00 4.5±0.07ms ? ?/sec 1.04 4.7±0.09ms ? ?/sec physical_plan_tpch_q21 1.00 6.1±0.07ms ? ?/sec 1.04 6.3±0.06ms ? ?/sec physical_plan_tpch_q22 1.00 3.3±0.06ms ? ?/sec 1.04 3.4±0.07ms ? ?/sec physical_plan_tpch_q3 1.00 3.1±0.05ms ? ?/sec 1.01 3.1±0.06ms ? ?/sec physical_plan_tpch_q4 1.00 2.3±0.05ms ? ?/sec 1.02 2.3±0.05ms ? ?/sec physical_plan_tpch_q5 1.00 4.5±0.07ms ? ?/sec 1.02 4.5±0.07ms ? ?/sec physical_plan_tpch_q6 1.00 1538.7±18.47µs ? ?/sec 1.03 1586.4±21.54µs ? ?/sec physical_plan_tpch_q7 1.00 5.7±0.08ms ? ?/sec 1.01 5.7±0.13ms ? ?/sec physical_plan_tpch_q8 1.00 7.3±0.10ms ? ?/sec 1.01 7.4±0.08ms ? ?/sec physical_plan_tpch_q9 1.00 5.6±0.09ms ? ?/sec 1.00 5.6±0.08ms ? ?/sec physical_select_all_from_1000 1.00 60.6±0.25ms ? ?/sec 1.01 61.4±0.29ms ? ?/sec physical_select_one_from_700 1.00 3.6±0.05ms ? ?/sec 1.02 3.7±0.04ms ? ?/sec ``` </p> </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
