jayzhan211 commented on code in PR #10386:
URL: https://github.com/apache/datafusion/pull/10386#discussion_r1590492848
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1670,17 +1734,106 @@ fn inlist_except(mut l1: InList, l2: InList) ->
Result<Expr> {
Ok(Expr::InList(l1))
}
+pub struct RewriteCycle {
+ consecutive_unchanged_count: usize,
+ total_iterations: usize,
+ num_rewriters: usize,
+}
+pub type RewriteCycleResult = ControlFlow<Result<Expr>, Expr>;
+
+impl RewriteCycle {
+ fn new() -> Self {
+ RewriteCycle {
+ // use usize::MAX as default to avoid checking null in is_done()
comparison
Review Comment:
Is the reason to avoid checking null because of cost? I'm fine with either
way, but curious on the choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
