phillipleblanc commented on issue #10414:
URL: https://github.com/apache/datafusion/issues/10414#issuecomment-2099555237
I agree that it makes sense to "pull the band-aid" and remove the syntax
from this code.
One place where I think this might get difficult is if an project that
relies on DataFusion has some sort of user/external input that relies on this
syntax, that the project itself doesn't have the ability to easily change. But
the nice thing about DataFusion is its extensible, so I could imagine if
someone has a strong requirement to keep the old syntax, we could write a
custom parser that wraps `DFParser` (maybe lives in another repo, or in
examples) that adds it back and just sets `OPTIONS('format.has_header'
'true')`. (See an example of a custom parser at
https://github.com/apache/datafusion/blob/main/datafusion-examples/examples/sql_dialect.rs#L45)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
