viirya commented on code in PR #412:
URL: https://github.com/apache/datafusion-comet/pull/412#discussion_r1597071283
##########
spark/src/main/spark-3.x/org/apache/comet/shims/ShimCometScanExec.scala:
##########
@@ -69,6 +69,8 @@ trait ShimCometScanExec {
readSchema: StructType,
options: ParquetOptions): FileScanRDD =
classOf[FileScanRDD].getDeclaredConstructors
+ // workaround for aws spark 3.4 implementation
+ .filter(c => List(3,5,6).contains(c.getParameterCount()) )
Review Comment:
Yea, I agreed.
I think we shouldn't claim after this PR that Comet can support AWS Spark.
The patch itself looks more like a fix to prevent the code uses incorrect
constructor which take different parameters.
For the perspective, it looks reasonable to me. But not to say that this
goes to support AWS Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
