Michael-J-Ward commented on issue #10424: URL: https://github.com/apache/datafusion/issues/10424#issuecomment-2105957139
Since the `regexp_*` UDFs have the same problem, I suspect that `array_slice` was just our first encounter w/ the underlying issue: any "inner" UDF implementation that behaves differently based on the number of arguments passed should expose that via its public API. Solutions discussed: 1) Expose multiple public apis for each variant, as @Omega359 pointed out that inner `substr` exposes public `substr` and `substring`. 2) Change the public APIs to take `Option<Expr>`, as I demoed for `array_slice` in #10450. 3) Having the public API just take a `Vec<Expr>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
