kazuyukitanimura commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1598977339
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -734,6 +734,23 @@ class CometSparkSessionExtensions
} else {
var newPlan = transform(plan)
+ // if the plan cannot be run fully natively then explain why (when
appropriate
+ // config is enabled)
+ if (CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.get()) {
+ new ExtendedExplainInfo().extensionInfo(newPlan) match {
Review Comment:
Unrelated, but I feel `ExtendedExplainInfo` can be `object`
##########
spark/src/main/scala/org/apache/comet/ExtendedExplainInfo.scala:
##########
@@ -45,7 +45,7 @@ class ExtendedExplainInfo extends ExtendedExplainGenerator {
}
}
- private def extensionInfo(node: TreeNode[_]): Set[String] = {
+ def extensionInfo(node: TreeNode[_]): Set[String] = {
Review Comment:
Perhaps `private[comet]` instead of public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
