viirya commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1593204526
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -734,6 +734,22 @@ class CometSparkSessionExtensions
} else {
var newPlan = transform(plan)
+ // if the plan cannot be run natively then explain why (when
appropriate config is enabled)
+ if (CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.get() &&
!isCometNative(newPlan)) {
Review Comment:
Comet could only trigger native execution for partial query plan. This check
`isCometNative(newPlan)` only applies for the top operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
