andygrove commented on code in PR #691: URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1599120965
########## src/expr.rs: ########## @@ -558,41 +553,9 @@ impl PyExpr { } }) } - - pub fn column_name(&self, plan: PyLogicalPlan) -> PyResult<String> { - self._column_name(&plan.plan()).map_err(py_runtime_err) - } } impl PyExpr { Review Comment: @jdye64 you may want to review this PR since it removes code that I believe you originally added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org