advancedxy opened a new pull request, #433: URL: https://github.com/apache/datafusion-comet/pull/433
## Which issue does this PR close? Closes #427 ## Rationale for this change Bug fixes. When submitting #344, we found there's a bug in spark_hash, which doesn't handle dictionary array correctly. This PR tries to fix this first. ## What changes are included in this PR? 1. refactor some part of spark_hash.rs and be ready for xxhash64 support 2. unpack dictionary when computing with hashes 3. updated test This PR currently depends on #426, will rebase once that's merged. ## How are these changes tested? Updated test with randomized input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
