andygrove commented on code in PR #416:
URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1601983256
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -948,10 +948,8 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
private def castTest(input: DataFrame, toType: DataType): Unit = {
- // we do not support the TryCast expression in Spark 3.2 and 3.3
+ // we now support the TryCast expression in Spark 3.2 and 3.3
// https://github.com/apache/datafusion-comet/issues/374
Review Comment:
nit: I don't think there is value in linking to an issue that is now
resolved. I would just remove this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
