viirya commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1603936564
########## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ########## @@ -948,10 +948,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { private def castTest(input: DataFrame, toType: DataType): Unit = { - // we do not support the TryCast expression in Spark 3.2 and 3.3 - // https://github.com/apache/datafusion-comet/issues/374 - val testTryCast = CometSparkSessionExtensions.isSpark34Plus - + // we now support the TryCast expression in Spark 3.2 and 3.3 Review Comment: nit: This comment looks unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org