alamb commented on code in PR #10529:
URL: https://github.com/apache/datafusion/pull/10529#discussion_r1602033644
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -391,7 +391,9 @@ impl Unparser<'_> {
Expr::ScalarVariable(_, _) => {
not_impl_err!("Unsupported Expr conversion: {expr:?}")
}
- Expr::IsNull(_) => not_impl_err!("Unsupported Expr conversion:
{expr:?}"),
+ Expr::IsNull(expr) => {
+ Ok(ast::Expr::IsNull(Box::new(self.expr_to_sql(expr)?)))
+ }
Expr::IsNotFalse(_) => not_impl_err!("Unsupported Expr conversion:
{expr:?}"),
Review Comment:
Ah it looks like I maybe mis read the code originally and the other missing
expression is `Expr::IsNotFalse` (rather than `Expr::IsNotNull`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
