viirya commented on code in PR #433:
URL: https://github.com/apache/datafusion-comet/pull/433#discussion_r1602578289
##########
core/src/execution/datafusion/spark_hash.rs:
##########
@@ -363,78 +368,64 @@ mod tests {
use crate::execution::datafusion::spark_hash::{create_hashes, pmod};
use datafusion::arrow::array::{ArrayRef, Int32Array, Int64Array,
Int8Array, StringArray};
- macro_rules! test_hashes {
- ($ty:ty, $values:expr, $expected:expr) => {
- let i = Arc::new(<$ty>::from($values)) as ArrayRef;
- let mut hashes = vec![42; $values.len()];
+ macro_rules! test_hashes_internal {
+ ($input: expr, $len: expr, $expected: expr) => {
+ let i = $input as ArrayRef;
+ let mut hashes = vec![42; $len];
create_hashes(&[i], &mut hashes).unwrap();
assert_eq!(hashes, $expected);
};
}
+ fn test_murmur3_hash<I: Clone, T: arrow_array::Array +
From<Vec<Option<I>>> + 'static>(
+ values: Vec<Option<I>>,
+ expected: Vec<u32>,
+ ) {
+ // copied before inserting nulls
+ let mut input_with_nulls = values.clone();
+ let mut expected_with_nulls = expected.clone();
Review Comment:
I guess you mean?
```suggestion
let mut expected_without_nulls = expected.clone();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
