berkaysynnada commented on PR #10504: URL: https://github.com/apache/datafusion/pull/10504#issuecomment-2117059842
> 3\. If all the inputs of a function are `Singleton`, should the output `SortProperties` also be `Singleton`? If so, maybe we can do this check once before calling individual monotonicity functions. For the most functions, it is so, but there could be edge cases like some time dependent functions or somehow depending randomly generated values. We have discussed it and decided to keep it as it is. I have addressed other minor issues, and this PR is ready to be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
