andygrove commented on code in PR #445:
URL: https://github.com/apache/datafusion-comet/pull/445#discussion_r1605843645
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -261,7 +261,10 @@ abstract class CometTestBase
}
val extendedInfo =
new
ExtendedExplainInfo().generateExtendedInfo(dfComet.queryExecution.executedPlan)
-
assert(extendedInfo.equalsIgnoreCase(expectedInfo.toSeq.sorted.mkString("\n")))
+ val expectedStr = expectedInfo.toSeq.sorted.mkString("\n")
+ if (!extendedInfo.equalsIgnoreCase(expectedStr)) {
+ fail(s"$extendedInfo != $expectedStr (case-insensitive comparison)")
+ }
Review Comment:
Improve message when this test fails.
Before:
```
extendedInfo.equalsIgnoreCase(expectedInfo.toSeq.sorted[[String](https://github.com/apache/datafusion-comet/pull/445/math.this.Ordering.String)](math.this.Ordering.String).mkString("\n"))
was false
```
After:
```
AQEShuffleRead is not supported
Native shuffle is not enabled: spark.comet.exec.shuffle.enabled is not
enabled != AQEShuffleRead is not supported
Native shuffle is not enabled (case-insensitive comparison)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
