tshauck commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1609228014
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1038,6 +1038,26 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
}
+ test("hex") {
+ Seq(true, false).foreach { dictionaryEnabled =>
+ withTempDir { dir =>
+ val path = new Path(dir.toURI.toString, "hex.parquet")
+ makeParquetFileAllTypes(path, dictionaryEnabled = dictionaryEnabled,
10000)
+
+ withParquetTable(path.toString, "tbl") {
+ // ints
+ checkSparkAnswerAndOperator("SELECT hex(_2), hex(_3), hex(_4),
hex(_5) FROM tbl")
+
+ // uints, uint8 and uint16 not working yet
+ // checkSparkAnswerAndOperator("SELECT hex(_9), hex(_10), hex(_11),
hex(_12) FROM tbl")
+ checkSparkAnswerAndOperator("SELECT hex(_11), hex(_12) FROM tbl")
+
+ // strings, binary
+ checkSparkAnswerAndOperator("SELECT hex(_8), hex(_14) FROM tbl")
Review Comment:
I updated dictionary handling, so I've added _13 back in. I think only the
smaller uints are omitted now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
