shanretoo commented on issue #6747: URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2125106167
Have you checked tests in [sqllogictest](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/window.slt)? If we want to make sure all the variants work as expected, I think we should add those tests in sqllogictest. And for the unit tests here, we can just check the situations that might have different results, for example, those default values we set in the builder functions. What do you think? You can take over this and I'm happy to help when needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
