aditanase commented on code in PR #10617:
URL: https://github.com/apache/datafusion/pull/10617#discussion_r1610233571
##########
datafusion/execution/src/runtime_env.rs:
##########
@@ -89,6 +89,27 @@ impl RuntimeEnv {
/// scheme, if any.
///
/// See [`ObjectStoreRegistry`] for more details
+ ///
+ /// # Examples
+ ///
+ /// Here's how to set up a local file system object store:
+ /// ```
+ /// let url = Url::try_from("file://").unwrap();
+ /// let object_store = object_store::local::LocalFileSystem::new();
+ /// ctx.runtime_env()
+ /// .register_object_store(&url, Arc::new(object_store));
+ /// ```
+ ///
+ /// Or how to set up a http object store:
+ /// ```
+ /// let base_url = Url::parse("https://github.com";).unwrap();
Review Comment:
Thanks so much for making these pass, I'll remember to run the doc tests
next time, only looked at the doc site before submitting the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
