davisp commented on PR #10590: URL: https://github.com/apache/datafusion/pull/10590#issuecomment-2125789754
@alamb That's an excellent point on the possible confusion between the two slightly different syntaxes for the same keyword in a statement. I obviously just went with what already existed but in hindsight that seems like some pretty fertile footgun ground best left untilled. I'll take a look at updating the parser to go with the `METADATA` keyword instead of `OPTIONS`. Just as a shortcut for my learning, would you expect that change to happen in the datafusion crates or in the sqlparser crate? I'm still not 100% on how that delineation works and given that the column `OPTIONS` isn't part of the dialect trait I'm not immediately certain where that change would be expected to happen. As to docs and bits, I knew I'd need to add something but figured I'd wait to get things generally agreed upon before spending too much time on the details. A related question I had was wether we'd want to update the Parquet compression option to use this approach at the same time (and anything else that has similar column specificity)? I've not read datafusion's deprecation policy, but adding it in a backwards compatible manner seems straightforward. Column metadata overriding the create options seems unsurprising while not breaking anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
